-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipping files and lines. #218
Conversation
Due to this, I think it would be better for this implementation to live inside that function entirely. After all, this is exactly ‘amending coverage from looking at the source code’. |
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 91.36% 90.85% -0.52%
==========================================
Files 6 6
Lines 336 361 +25
==========================================
+ Hits 307 328 +21
- Misses 29 33 +4
Continue to review full report at Codecov.
|
Resolved conflicts and moved the line-by-line functionality to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks...
could you also perhaps git rebase master
?
7c533c7
to
3fcb26c
Compare
bc66bff
to
7d18c7a
Compare
Co-Authored-By: Jameson Nash <[email protected]>
…verage.jl into skip_files_and_lines
So I have all the test working now locally, but both Travis and AppVeyor keep failing. If anyone has any pointers, that would be much appreciated. |
@zundertj Why did you delete the file |
@zundertj On an unrelated note, could you edit the original post to have the following content exactly? That way, when this PR is merged, GitHub will automatically close the mentioned issues and pull requests. (But you have to use those specific words like |
Now that the core functionality has been factored out to CoverageTools.jl, this PR will need to be made to the https://github.com/JuliaCI/CoverageTools.jl repository. |
Work in progress; just setting this up to get your input.
Adresses #53 & #44; supersedes #55.
Main design issues/questions/todo's:
.coverage.yml
file only affect files in the folder, or also sub folders? I guess most packages have just a single src folder, but having to specify the exclusion pattern for each and every folder in case there are multiple seems tedious to me, in particular for the line pattern. Alternatively, a much simpler solution would be to simply have a toggle or default regex in the API, removing the need for the.coverage.yml
file for the line patterns altogether. That does not allow one to completely exclude files tough.amend_coverage_from_src
modifies the results afterwards. There is more code change coming for that function (PR214), so I did not want to touch that function right now. To make this work, it seems that we have to reorganize these two functions. I'm happy to do that once the dust is settled, if you agree that is the right approach.Fixes #44
Fixes #53
Closes #55